Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minReplicaCount, remove replicas if autoscaling is enabled #1932

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Add minReplicaCount, remove replicas if autoscaling is enabled #1932

merged 5 commits into from
Sep 11, 2023

Conversation

williamlac
Copy link
Contributor

@williamlac williamlac commented Sep 4, 2023 •
edited
Loading

Description

Add minReplicaCount to browsers hpa.yaml files.
This fixes issue #1930 where I opened a feature request for it.

Breaking change:
This also removes replicas if autoscaling is enabled. If we are talking about autoscaling we should consider min/max replicas.
replicas should be used when no autoscaling is invoved

Motivation and Context

This will allow autoscaling of type deployment to have a minimum number of replicas

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@williamlac williamlac marked this pull request as ready for review September 4, 2023 14:26
@farioas
Copy link

farioas commented Sep 4, 2023

It's not recommended to use idleReplicaCount at all:

  1. https://keda.sh/docs/2.10/concepts/scaling-deployments/#idlereplicacount -- see NOTE
  2. Add a detailed description of the "idleReplicaCount" field, along with an example. kedacore/keda-docs#1186 - pending documentation change into existing KEDA documentation.

My suggestion is to remove idleReplicaCount argument and leave only minReplicaCount and maxReplicaCount

@williamlac
Copy link
Contributor Author

It's not recommended to use idleReplicaCount at all:

  1. https://keda.sh/docs/2.10/concepts/scaling-deployments/#idlereplicacount -- see NOTE
  2. Add a detailed description of the "idleReplicaCount" field, along with an example. kedacore/keda-docs#1186 - pending documentation change into existing KEDA documentation.

My suggestion is to remove idleReplicaCount argument and leave only minReplicaCount and maxReplicaCount

Thanks for the heads up. Removed it

@williamlac williamlac changed the title Add minReplicaCount and idleReplicaCount Add minReplicaCount Sep 5, 2023
@williamlac
Add minReplicaCount and idleReplicaCount
7892af3 
Add minReplicaCount and idleReplicaCount to browsers hpa.yaml files. And update doc
@williamlac
Fix doc
5535d48
@williamlac
Remove idleReplicaCount
4f11fa5
@williamlac williamlac force-pushed the feat-min-and-idle-replica-count branch from 92cbb93 to 4f11fa5 Compare September 5, 2023 08:05
@williamlac williamlac changed the title Add minReplicaCount Add minReplicaCount, remove replicas if autoscaling is enabled Sep 5, 2023
@diemol diemol merged commit 627f50d into SeleniumHQ:trunk Sep 11, 2023
This was referenced Sep 11, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamlac @CLAassistant @farioas @diemol